cockroachdb / cockroachdb/cockroach
opt: clarify `tree.OnConflict.Where` and `tree.OnConflict.ArbiterPredicate`
Open
branch-master
C-cleanup
T-sql-queries
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
These fields are different in subtle ways, and they are completed undocumented. This has caused some confusion, see https://github.com/cockroachdb/cockroach/pull/132511#pullrequestreview-2377056466.
We should add clarifying comments and potentially rename them to avoid future confusion.
Jira issue: CRDB-43307
Contributor guide
Assessment
This issue has not been assessed yet.