cockroachdb / cockroachdb/cockroach

kv: audit uses of (roachpb.Value).RawBytes

Open
#131,664 1 comment 0 reactions 0 assignees View on GitHub
C-bug T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

In #131348 we have added an option that allows senders of GetRequest and ScanRequest to request. In the future we may consider making this option the default, but before that is possible, we need to be sure that existing users of the RawBytes aren't interacting with that fields in a way incompatible with the extended encoding. This includes:

- Callers checking `len(value.RawBytes) == 0` or `value.RawBytes == nil` to determine if a value is tombstone.
- Callers attempting to manually parse RawBytes without the aid of the helper methods on `roachpb.Value`.
-

Jira issue: CRDB-42646

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.