cockroachdb / cockroachdb/cockroach
kvflowcontrol: leaseholder not leader doesn't admit via store work queue
Open
branch-master
branch-release-23.2
branch-release-24.1
branch-release-24.2
branch-release-24.3
C-bug
T-admission-control
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
When a leaseholder replica doesn't hold the lease, replication flow control v1 skips admission via replication flow control ([here](https://github.com/cockroachdb/cockroach/blob/832ba884372be378e811a20d66f0d39b3d27a3ab/pkg/kv/kvserver/kvadmission/kvadmission.go#L342-L344)) because the leader maintains flow token state.
However, in replication flow control v1, we also skip admitting via the `StoreWorkQueue` -- so no AC backpressure is applied.
Jira issue: CRDB-42303
Contributor guide
Assessment
This issue has not been assessed yet.