cockroachdb / cockroachdb/cockroach

sql/logictest: implement "subtest end"

Open
#130,455 0 comments 0 reactions 0 assignees View on GitHub
C-enhancement
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The [datadriven](https://github.com/cockroachdb/datadriven/blob/master/datadriven.go#L233-L235) package supports ending subtests with the "subtest end" command. We use this prolifically in logictests, even though there is no explicit support for this command - it simply starts a new subtest named "end". We should correctly support "subtest end" with the behavior:

1. All subtests must be explicitly "ended".
2. Subtests cannot have the name "end".

Jira issue: CRDB-42059

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.