cockroachdb / cockroachdb/cockroach
cdc: clean up the NetMetrics injection
Open
A-cdc
C-enhancement
T-cdc
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
To ease backporting, the NetMetrics were added to the `AggMetrics` for changefeeds. They don't follow the same pattern as the other `sliMetrics` and should be in a different struct. This would require a larger change to the metrics to implement.
Ideally instead of passing a `metricsRecorderBuilder` which only contains a `metricsRecorder` (which is a `sliMetrics`), we would pass in an interface that could get both the `sliMetrics` as well as the `NetMetrics` for the connection.
Jira issue: CRDB-42015
Contributor guide
Assessment
This issue has not been assessed yet.