cockroachdb / cockroachdb/cockroach

kvserver/liveness: liveness storage sends batch requests without admission header

Open
#130,014 2 comments 0 reactions 0 assignees View on GitHub
A-admission-control branch-master C-bug T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

At least one source of the reports found in #112680 is likely the following to uses of the Get and Scan methods on`kv.DB` in liveness.Storage:

https://github.com/cockroachdb/cockroach/blob/a1cfb1b5573b1f606ea9527ae93025c2ef667e4e/pkg/kv/kvserver/liveness/storage.go#L73

https://github.com/cockroachdb/cockroach/blob/a1cfb1b5573b1f606ea9527ae93025c2ef667e4e/pkg/kv/kvserver/liveness/storage.go#L201

Replacing these two uses a db.Txn() avoids the warning in a good number of the reproductions I've seen locally. We likely don't want a Txn here though, so we'll want to use a different API that allows us to pass in an admission header.

Jira issue: CRDB-41842

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.