cockroachdb / cockroachdb/cockroach
kvserver/rangefeed: memory accounting is missing for catch up scans
Open
A-kv-rangefeed
branch-master
C-bug
T-kv
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
**Describe the problem**
Previously, we introduced memory accounting to rangefeed. However, catch up scans are not subject to memory accounting afaict https://github.com/cockroachdb/cockroach/blob/2f8519c1ae5020614ee1616c829e1d5b3702f942/pkg/kv/kvserver/rangefeed/catchup_scan.go#L143. We should also consider using sync.Pool (like real live events memory accounting) to reduce allocations if possible. We didn't fully address the issue described in https://github.com/cockroachdb/cockroach/issues/73616 and https://github.com/cockroachdb/cockroach/issues/69596.
Jira issue: CRDB-41355
Contributor guide
Assessment
This issue has not been assessed yet.