cockroachdb / cockroachdb/cockroach

cli: better guardrail against max-offset misconfiguration

Open
#128,959 1 comment 0 reactions 0 assignees View on GitHub
A-cli-flags A-cli-server branch-master C-enhancement E-starter O-support P-3 T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Is your feature request related to a problem? Please describe.**

In a recent issue[^1], a user started a single node using `--max-offset=5000ms`
(combined with `--disable-max-offset-check`) to evaluate performance of an
insert workload. However, CRDB really isn't functional with a `--max-offset` of
that magnitude; max offsets must not exceed be a small fraction of the liveness
heartbeat interval.

We could've saved a good amount of time diagnosing this had it been impossible
to start a server with this value.

[^1]: https://github.com/cockroachdb/cockroach/issues/127969#issuecomment-2288629720

**Describe the solution you'd like**

Refuse to start with `--max-offset` outside an admissible range.

**Describe alternatives you've considered**

**Additional context**

See #127969.

Jira issue: CRDB-41304

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.