cockroachdb / cockroachdb/cockroach
insights: stop pooling insights.Insight objects
Open
branch-release-23.2
branch-release-24.1
branch-release-24.2
C-bug
T-observability
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
**Describe the problem**
Currently we pool Insight objects which does not make a lot of sense since we put those in a cache once they're generated. The release into the pool also does not clear the statements slice which can lead to mem leaks. What we probably want to start doing is pooling the insight.Statement object since those are created for every statement and most statements are assumed to not make it into the insights cache.
Affected: 23.1+
Jira issue: CRDB-40861
Contributor guide
Assessment
This issue has not been assessed yet.