cockroachdb / cockroachdb/cockroach

storage: allow disabling value blocks via cluster setting

Open
#127,678 3 comments 0 reactions 1 assignee Claimed by @sumeerbhola View on GitHub
backport-23.2.x backport-24.1.x branch-master C-bug
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

This will also require a change to Pebble, since value blocks are enabled for sstable formats >= TableFormatPebblev3.

In a production cluster, 1000s of versions of a single large k-v pair resulted in a > 100GiB range, and since we write a single sstable for the state machine during an incoming snapshot, we attempted to write a > 100GiB sstable that had to buffer the compressed values in memory, resulting in an OOM.

Jira issue: CRDB-40546

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.