cockroachdb / cockroachdb/cockroach

admission: integrate snapshot send with CPU limiter

Open
#127,434 0 comments 0 reactions 0 assignees View on GitHub
A-admission-control C-enhancement O-testcluster T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Along with https://github.com/cockroachdb/cockroach/issues/123682 (which focussed on the receiver), we should also shape the sender of snapshots using the CPU limiter.

In an [internal discussion ](https://cockroachlabs.slack.com/archives/C01SRKWGHG8/p1721291600405649), we saw CPU profiles for the sender show high CPU usage.

Profile:
![image](https://github.com/user-attachments/assets/1788aa9b-386c-4801-8d2e-4cb621249a67)

Jira issue: CRDB-40438

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.