cockroachdb / cockroachdb/cockroach

when creating an external connection, dial the canary sink rather than just create it

Open
#126,992 7 comments 0 reactions 0 assignees View on GitHub
A-cdc C-enhancement E-easy T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

when we create an external connection, we create a canary sink to validate the configuration, like we do with regular feeds. however, we don't call Dial() on that sink, so the validation is less thorough. fix this.

see https://github.com/asg0451/cockroach/blob/366e7082bcd58edc28d01273f112dac61dcce3d9/pkg/ccl/changefeedccl/sink_external_connection.go#L86

Jira issue: CRDB-40226

Contributor guide

Open the contributing guide

Research direction

Open pkg/ccl/changefeedccl/sink_external_connection.go around line 86 and compare external-connection canary validation with the regular-feed behavior described in the issue. Trace where the canary sink is created and how Dial() is used; the work is done when external-connection validation also dials the canary sink before accepting the configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend, databases
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.