cockroachdb / cockroachdb/cockroach

server: background job inheriting from cluster setting

Open
#126,806 0 comments 0 reactions 0 assignees View on GitHub
C-enhancement
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

In https://github.com/cockroachdb/cockroach/pull/101486, we started inheriting from cluster settings. This change makes it so that instead of the go default for session variables, background jobs inherit from the global default (cluster setting's) value. This does not make particular sense in cases like statement timeouts. There may be other instances where we do not prefer global defaults to be applied to background jobs; this issue will track the existence of the pattern.

For a fix/more context, see: https://github.com/cockroachdb/cockroach/pull/126336, https://github.com/cockroachlabs/support/issues/2998

Jira issue: CRDB-40144

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.