cockroachdb / cockroachdb/cockroach
sql: consider making walk machinery walk the entire expression tree
Open
A-sql-syntax
C-enhancement
T-sql-queries
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
Currently, `tree.WalkExpr` is not guaranteed to walk all nodes in a given expression tree. This is confusing and has led to bugs in the past, and also limits the usability of the logic. We should consider changing this. See also https://github.com/cockroachdb/cockroach/blob/6478524d42031106c5f0cc484a832ca9383fc6d1/pkg/sql/sem/tree/walk.go#L827-L832
Jira issue: CRDB-40093
Contributor guide
Assessment
This issue has not been assessed yet.