cockroachdb / cockroachdb/cockroach

Improving the tracing of the declarative schema changer

Open
#126,284 0 comments 0 reactions 0 assignees View on GitHub
C-enhancement T-sql-foundations
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Is your feature request related to a problem? Please describe.**

Currently, when a declarative schema changer is running, we capture trace data under a single span called 'NEW SCHEMA CHANGE.' It would be better to have more granular trace support so that we can identify when the different phases start and end.

**Describe the solution you'd like**
We can do two things:
- Create a new span when we wait in waitForOneVersion and waitForNoVersion. Since these functions can be time-consuming, it would be helpful to see their occurrences in the Jaeger output.
- Create a new span for each stage of the schema change. This will allow us to clearly see what stage we are in when inspecting the trace of a schema change that is still running.

Jira issue: CRDB-39832

Epic CRDB-42485

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.