sql: optimizer folds away constants in arithmetic equality comparisons

pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload [failed](https://tanzanite.cluster.engflow.com/invocations/default/d69323ef-e091-4fed-90c4-28a75281fe8b?testReportRun=21&testReportShard=1&testReportAttempt=1#targets-Ly9wa2cvY2NsL3Rlc3RjY2wvd29ya2xvYWQvc2NoZW1hY2hhbmdlOnNjaGVtYWNoYW5nZV90ZXN0) on release-24.1.2-rc @ [35c3e0c133c56c91399e730f49bc488cf6dd4c11](https://github.com/cockroachdb/cockroach/commits/35c3e0c133c56c91399e730f49bc488cf6dd4c11):

```
},
{
"query": "SELECT ARRAY[parent.table_schema, parent.table_name, quote_ident(parent.column_name), quote_ident(child.column_name)] FROM (SELECT conname, conkey, confkey, conrelid, confrelid FROM pg_constraint WHERE (contype = 'f') AND (conrelid = 'schema_w0_26.table_w1_16'::REGCLASS::INT8)) AS con JOIN (SELECT column_name, ordinal_position, column_default FROM information_schema.columns WHERE (table_schema = 'schema_w0_26') AND (table_name = 'table_w1_16')) AS child ON conkey[1] = child.ordinal_position JOIN (SELECT pc.oid, cols.table_schema, cols.table_name, cols.column_name, cols.ordinal_position FROM pg_class AS pc JOIN pg_namespace AS pn ON pc.relnamespace = pn.oid JOIN information_schema.columns AS cols ON ((pc.relname = cols.table_name) AND (pn.nspname = cols.table_schema))) AS parent ON ((con.confkey[1] = parent.ordinal_position) AND (con.confrelid = parent.oid)) WHERE child.column_name != 'rowid'",
"result": null
}
],
"previousStatements": [
"CREATE SEQUENCE IF NOT EXISTS schema_w1_13.seq_w1_15",
"CREATE TABLE schema_w0_26.table_w1_16 (col16_w1_17 BYTES NOT NULL, col16_w1_18 BOOL, \"col1'6_w1_19\" STRING COLLATE de_DE NOT NULL, \"co!l16_w1_20\" FLOAT8 NOT NULL, col16_w1_21 OID NULL, \"co l16_w1_22\" \"char\" NULL, col16_w1_23 OID, col16_w1_24 NAME NOT NULL, \"c!ol16_w1_25\" JSONB NULL, \"/co\"\"l16_w1_26\" INT4 NULL, \"col16'_w1_27\" FLOAT8 NOT NULL, col16_w1_28 GEOMETRY NOT NULL, col16_w1_29 BYTES, col16_w1_30 INTERVAL, \"col16\\\\xa4_w1_31\" JSONB NOT NULL, \"c̍ol\r16_w1_32\" INT8 NULL, col16_w1_33 FLOAT4 NULL, UNIQUE ((\"c̍ol\r16_w1_32\" + \"/co\"\"l16_w1_26\") ASC), INDEX (col16_w1_21 ASC) STORING (col16_w1_18, \"co l16_w1_22\", col16_w1_24, col16_w1_28, col16_w1_29, col16_w1_30, \"col16\\\\xa4_w1_31\", col16_w1_33) VISIBILITY 0.35, UNIQUE (col16_w1_21, col16_w1_33 ASC, \"co l16_w1_22\", \"co!l16_w1_20\", col16_w1_24, \"/co\"\"l16_w1_26\" ASC, col16_w1_23 DESC, \"c!ol16_w1_25\", \"col1'6_w1_19\" ASC, col16_w1_29 ASC, \"col16'_w1_27\" DESC, col16_w1_30 DESC) STORING (\"c̍ol\r16_w1_32\"), INDEX (\"/co\"\"l16_w1_26\" DESC) VISIBILITY 0.78, UNIQUE (\"co!l16_w1_20\" DESC) STORING (\"col1'6_w1_19\", \"co l16_w1_22\", col16_w1_23, \"c!ol16_w1_25\", col16_w1_29, \"c̍ol\r16_w1_32\", col16_w1_33), UNIQUE (\"c̍ol\r16_w1_32\", \"c!ol16_w1_25\" ASC) STORING (col16_w1_18, col16_w1_21, \"co l16_w1_22\", col16_w1_23, \"col16'_w1_27\", col16_w1_29), UNIQUE (col16_w1_17 ASC, col16_w1_23 DESC, \"/co\"\"l16_w1_26\", (\"co!l16_w1_20\" + col16_w1_33) ASC, \"c̍ol\r16_w1_32\" DESC, col16_w1_30 ASC, \"col1'6_w1_19\" DESC, col16_w1_18 ASC, col16_w1_33, \"co l16_w1_22\" DESC, col16_w1_21 DESC, col16_w1_24, \"col16\\\\xa4_w1_31\"), INDEX (((col16_w1_33 + \"co!l16_w1_20\") + \"col16'_w1_27\") DESC, col16_w1_17 DESC) STORING (\"co!l16_w1_20\", \"co l16_w1_22\", \"c!ol16_w1_25\", \"/co\"\"l16_w1_26\", col16_w1_28, col16_w1_30, \"col16\\\\xa4_w1_31\", \"c̍ol\r16_w1_32\", col16_w1_33), FAMILY (col16_w1_28), FAMILY (\"c!ol16_w1_25\", \"/co\"\"l16_w1_26\", \"col1'6_w1_19\"), FAMILY (col16_w1_17, \"co!l16_w1_20\", \"c̍ol\r16_w1_32\"), FAMILY (col16_w1_23), FAMILY (\"col16'_w1_27\", col16_w1_33, col16_w1_18), FAMILY (col16_w1_29, col16_w1_21, col16_w1_30, \"co l16_w1_22\"), FAMILY (\"col16\\\\xa4_w1_31\", col16_w1_24))",
"INSERT INTO schema_w0_26.table_w1_16 (col16_w1_17,col16_w1_18,\"col1'6_w1_19\",\"co!l16_w1_20\",col16_w1_21,\"co l16_w1_22\",col16_w1_23,col16_w1_24,\"c!ol16_w1_25\",\"/co\"\"l16_w1_26\",\"col16'_w1_27\",col16_w1_28,col16_w1_29,col16_w1_30,\"col16\\\\xa4_w1_31\",\"c̍ol\r16_w1_32\",col16_w1_33) VALUES ('\\x023ced01':::BYTES,false,e'\\U000EB4C9\\U000736C7\\U000099C0\\U000921E5\\U00045705' COLLATE de_DE,0.0:::FLOAT8,3615:::OID,'r'::\"char\",90000:::OID,e'\\x1b\u003eb\\'\\x1a'::NAME:::NAME,'[{\"1hv\": 0.38380800823336125, \"7WxqdP4AB\": null, \"baz\": [null, null, \"foobar\"], \"foo\": 0.907397094710884, \"ugRAfVWU\": {\"JQJcy\": {\"a\": null, \"bar\": 3.002055136213273, \"baz\": null, \"c\": true, \"nGgF\": 2.17228485738689}, \"b\": 4.230072051680517, \"c\": null}}, [{\"SUakUeu3\": true, \"foo\": null}, true, true, \"40Trg\"], [true, \"Q7\"], 1.5442406476676414, false]':::JSONB,37:::INT8,0.03362331446017158:::FLOAT8,'01030000400100000009000000304B18C62C5BFEC14264212D9682E5C1ACE2193BAAC0E9C17890B0335096F3C1945BFC082192DCC1CC133593BEC3FB41D29EC1A5C5F5EAC1F0B6A0765CEDFAC1BC637B436FCCFCC1806F3BC1D4D8CAC170CE868D214DDEC1B26E314677B7E8C1181495FB3FB3FC41E029FDF0E578F1419E82ECF1A49702C2845C6BED763CE2C1386212840ADDD841E44EA06D06CCFCC1F204676B0AF7F7C1E67DDCA38677FA413CC0E76D70F9DBC1F777FC922135FEC14C56870AB8E2F64150F683983E32F041304B18C62C5BFEC14264212D9682E5C1ACE2193BAAC0E9C1':::GEOMETRY,'\\x':::BYTES,'-46 years -5 mons -223 days -05:40:23.327262':::INTERVAL,'{\"M67m\": [\"uO\"], \"QlAJ8\": 0.2984358503836573, \"bar\": false, \"baz\": [false, true]}':::JSONB,35:::INT8,NULL),('\\xfbd8549fcb4aaefc':::BYTES,false,e'\\U0009C42B\\U00085B2A\\U000C744F\\U000E4FDF\\U0002BB56\\U000A35F5\\U000426AC\\U000A9710\\U00090456' COLLATE de_DE,(-0.0):::FLOAT8,25:::OID,e'\\t'::\"char\",25:::OID,'xv'::NAME:::NAME,'{\"Vbd7hGv\": null, \"b\": false, \"foo\": null, \"foobar\": true, \"xGb\": [true, \"F7S31Rn\", null]}':::JSONB,(-14):::INT8,(-0.0):::FLOAT8,'010300000001000000040000005E8185305D1FFBC16EB241EE4693F9C10C7AD3BEE23EFC410275525CE3AE004250C11B155577DB41C88EE1720F1EF9415E8185305D1FFBC16EB241EE4693F9C1':::GEOMETRY,'\\x8fa9d3':::BYTES,'22 years 7 mons 766 days 21:10:49.653636':::INTERVAL,'{\"baz\": null, \"ekOJV\": \"baz\", \"foobar\": [{\"WT5\": \"ivo\", \"c\": \"ZjK\", \"pvrkZrlV4\": null}, 0.1520572319319641]}':::JSONB,80:::INT8,(-0.5707768797874451):::FLOAT8),('\\x4a865ab00cdb26':::BYTES,true,e'\\U000544BC\\U00034862\\U00002365\\U000D1477\\U00014352\\U0007CE3F\\U00012D93\\U000CED2B\\U000B2E39' COLLATE de_DE,0.565243544913826:::FLOAT8,23:::OID,NULL,1042:::OID,e'W,a\\x14oDzEs'::NAME:::NAME,'{\"TaspG7Xh\": null, \"Wp4ACJz\": [true, false], \"foo\": false}':::JSONB,(-92):::INT8,(-0.6868296594875365):::FLOAT8,'0104000040070000000101000040ACE6E1B8B953EB41F5745416CC32F2C180A1B2C83E87BE410101000040E81D08607E98DEC1FA67C4BC84C4FFC14C71DCEC952EEA4101010000400003AB4BC52EAEC1C28E8A14C92901C2A6F239AC41B7ECC10101000040F0B8E7A76A4FCB4146674AC6E246FFC1429E28587AA6FBC101010000401ED2ED63E2C200C214B7ABD0CC19E4415844B6500516EA410101000040F69ED0814A16E2C190DB9023B8D2EE41ECEDCD117894F4C101010000405076B681EA99F0C1F85A8036D74AF1416E4E1EDAED980242':::GEOMETRY,'\\x99de039695':::BYTES,'-60 years -6 mons -67 days -22:19:34.49658':::INTERVAL,'{\"CNUC\": [\"foobar\", false], \"J6kVDa5sR\": 1.1159178169162471, \"PpU1S\": [0.8765462788257372, null, 2.5343532601068546], \"c\": {\"1gnkJe\": true, \"a\": 0.09615373174932818, \"bar\": [[{\"bB\": false}, true], true, {\"c\": 2.0295542174376866, \"foobar\": 0.2833705668899665}, 2.8665298085920394, true], \"prrOQpZ\": false}}':::JSONB,125:::INT8,(-0.6805527806282043):::FLOAT8)"
]
}
}
schema_change_external_test.go:132:
Error Trace: pkg/ccl/testccl/workload/schemachange/schemachange_test_test/pkg/ccl/testccl/workload/schemachange/schema_change_external_test.go:132
Error: Received unexpected error:
***UNEXPECTED ERROR; Received an unexpected execution error.: ERROR: duplicate key value violates unique constraint "table_w1_16_co!l16_w1_20_key" (SQLSTATE 23505)
(1) forced error mark
| "fatal error when running txn"
| github.com/cockroachdb/errors/withstack/*withstack.withStack::
Wraps: (2)
Wraps: (3) attached stack trace
-- stack trace:
| github.com/cockroachdb/cockroach/pkg/workload/schemachange.(*opStmt).executeStmt
| github.com/cockroachdb/cockroach/pkg/workload/schemachange/operation_generator.go:3120
| github.com/cockroachdb/cockroach/pkg/workload/schemachange.(*schemaChangeWorker).runInTxn
| github.com/cockroachdb/cockroach/pkg/workload/schemachange/schemachange.go:511
| github.com/cockroachdb/cockroach/pkg/workload/schemachange.(*schemaChangeWorker).run
| github.com/cockroachdb/cockroach/pkg/workload/schemachange/schemachange.go:605
| pkg/ccl/testccl/workload/schemachange/schemachange_test_test.TestWorkload.TestWorkload.func4.func6
| pkg/ccl/testccl/workload/schemachange/schemachange_test_test/pkg/ccl/testccl/workload/schemachange/schema_change_external_test.go:121
| golang.org/x/sync/errgroup.(*Group).Go.func1
| golang.org/x/sync/errgroup/external/org_golang_x_sync/errgroup/errgroup.go:78
| runtime.goexit
| src/runtime/asm_amd64.s:1695
Wraps: (4) ***UNEXPECTED ERROR; Received an unexpected execution error.
Wraps: (5) ERROR: duplicate key value violates unique constraint "table_w1_16_co!l16_w1_20_key" (SQLSTATE 23505)
Error types: (1) *markers.withMark (2) *schemachange.ErrorState (3) *withstack.withStack (4) *errutil.withPrefix (5) *pgconn.PgError
Test: TestWorkload
Schema Workload Stats
Total Schema Statements Executed = 36
Total Schema Statements Succeeded = 36
Total Schema Statement Expected Failures = 0
Total Transactions Committed = 21
Total Transactions Rolled Back = 43
Total Transactions Executed = 64
schema_change_external_test.go:98: backup, tracing data, and system table dumps in /var/lib/engflow/worker/work/1/exec/bazel-out/k8-fastbuild/testlogs/pkg/ccl/testccl/workload/schemachange/schemachange_test/run_21_of_25/test.outputs/logTestWorkload2109485748
panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestWorkload2109485748
--- FAIL: TestWorkload (11.98s)
```

Parameters:
- attempt=1
- run=21
- shard=1
Help

See also: [How To Investigate a Go Test Failure \(internal\)](https://cockroachlabs.atlassian.net/l/c/HgfXfJgM)

/cc @cockroachdb/sql-foundations

[This test on roachdash](https://roachdash.crdb.dev/?filter=status:open%20t:.*TestWorkload.*&sort=title+created&display=lastcommented+project) | [Improve this report!](https://github.com/cockroachdb/cockroach/tree/master/pkg/cmd/bazci/githubpost/issues)

Jira issue: CRDB-39611