cockroachdb / cockroachdb/cockroach

kvcoord: improve logging in mux rangefeed

Open
#125,669 2 comments 1 reaction 0 assignees View on GitHub
A-kv-client A-kv-rangefeed C-enhancement O-support P-3 T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Is your feature request related to a problem? Please describe.**

Currently, all of the logging in `dist_sender_mux_rangefeed.go` is behind a verbosity flag. It makes debugging issues like https://github.com/cockroachlabs/support/issues/2980, where we want to answer questions about why we weren't able to establish a rangefeed hard. We should consider logging failure/retry scenarios normally; if these prove to be too verbose, maybe we can only log after x attempts and/or introduce a new logging channel here.

cc @wenyihu6

Jira issue: CRDB-39545

Epic CRDB-54646

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.