cockroachdb / cockroachdb/cockroach

storage: improve block load metrics

Open
#125,075 1 comment 0 reactions 1 assignee Claimed by @RaduBerinde View on GitHub
A-storage branch-master C-bug C-escalation-improvement T-storage
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

We currently have these two metrics:
```
metaBlockBytes = metric.Metadata{
Name: "storage.iterator.block-load.bytes",
Help: "Bytes loaded by storage engine iterators (possibly cached). See storage.AggregatedIteratorStats for details.",
Measurement: "Bytes",
Unit: metric.Unit_BYTES,
}
metaBlockBytesInCache = metric.Metadata{
Name: "storage.iterator.block-load.cached-bytes",
Help: "Bytes loaded by storage engine iterators from the block cache. See storage.AggregatedIteratorStats for details.",
Measurement: "Bytes",
Unit: metric.Unit_BYTES,
}
```

In practice, the most likely figure we would be interested in is the difference between these two, i.e. how many bytes we read. We should replace the total value with the non-cached value.

Jira issue: CRDB-39220

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.