cockroachdb / cockroachdb/cockroach

bazel: difficult to get `nogo` to ignore all third-party code

Open
#124,154 0 comments 0 reactions 0 assignees View on GitHub
A-build-system C-enhancement T-dev-inf
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

To ignore certain files in `nogo`, we need to pass in a regex to match the filename as described [here](https://github.com/bazelbuild/rules_go/blob/master/go/nogo.rst#configuring-analyzers). However, there is no one regex that allows us to reliably recognize all third-party code and match no first-party code. Ideally, this should be a "meta" thing where `nogo` can simply check what is or is not in `external` and allow configuring that directly.

Epic: CRDB-17171

Jira issue: CRDB-38733

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.