cockroachdb / cockroachdb/cockroach

changefeedccl: support azure-blob prefix for azure blob storage sink

Open
#124,074 4 comments 0 reactions 0 assignees View on GitHub
A-cdc C-bug E-easy T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

CDC documentation advertises `azure-blob` as the prefix for azure blob storage, but this is not included in [isCloudStorageSink()](https://github.com/cockroachdb/cockroach/blob/master/pkg/ccl/changefeedccl/sink_cloudstorage.go#L46), so using it results in an `unsupported sink: azure-blob` error. The code in [azure_storage.go](https://github.com/cockroachdb/cockroach/blob/master/pkg/cloud/azure/azure_storage.go#L428) suggests that the `azure` prefix is deprecated in favor of `azure-blob`, so we should complete support for `azure-blob`.

Jira issue: CRDB-38685

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.