cockroachdb / cockroachdb/cockroach

*: evaluate uses of `skip.Stress()`

Open
#123,909 1 comment 0 reactions 0 assignees View on GitHub
C-enhancement T-dev-inf
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

With the RBE-based CI and nightlies, this variable will not be set in CI, which means that `skip.Stress()` will always return `false`. The following uses of it should be evaluated and maybe replaced with alternatives.

```
cockroach$ rg skip.Stress
pkg/sql/plan_opt_test.go
118: if !skip.Stress() {

pkg/sql/mvcc_statistics_update_job_test.go
211: if skip.Stress() {

pkg/ccl/streamingccl/replicationtestutils/testutils.go
494: if skip.Stress() || util.RaceEnabled {

pkg/ccl/kvccl/kvtenantccl/upgradeinterlockccl/local_test_util_test.go
113: if skip.Stress() {

```

See also:
#123907
#123908

Jira issue: CRDB-38598

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.