cockroachdb / cockroachdb/cockroach

pg_catalog: fix up contents of `pg_catalog.pg_proc`

Open
#123,651 0 comments 0 reactions 0 assignees View on GitHub
A-sql-pgcompat C-cleanup O-pg-regress T-sql-foundations
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Currently, when running `opr_sanity.sql` subtest of `pg_regress` test suite, we get lots of rows on queries that should be returning none, indicating that some illegal values / incomplete information is present. For now, in order to avoid unnecessary churn of the pg_regress diff file when adding new builtins, we'll skip `opr_sanity.sql` altogether.

Jira issue: CRDB-38448

Epic CRDB-60809

Contributor guide

Open the contributing guide

Research direction

Start with the pg_catalog.pg_proc contents and the opr_sanity.sql subtest in the pg_regress test suite. Identify the illegal values or incomplete information producing rows where queries should return none, then verify the catalog corrections against the regression output. Done means opr_sanity.sql can run without the current failures or unnecessary diff churn.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.