cockroachdb / cockroachdb/cockroach

bazel: `copy_directory`, `copy_to_directory` bits are not in the `distdir`

Open
#123,249 0 comments 0 reactions 0 assignees View on GitHub
A-build-system C-enhancement T-dev-inf
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

These directories are mirrored and the repositories are initialized in `build/nodejs.bzl`, but the stuff is not captured from `generate-distdir`.

Separately, we should evaluate if future versions of `rules_js` will still need this utility. If not, then this stuff can be removed from our repo.

This item may become stale if [DEVINF-1126](https://cockroachlabs.atlassian.net/browse/DEVINF-1126) is worked on.

Epic: CRDB-17171

Jira issue: CRDB-38258

Contributor guide

Open the contributing guide

Research direction

Start with build/nodejs.bzl and the generate-distdir process to trace how the mirrored repositories are initialized and which contents are captured. Confirm whether copy_directory and copy_to_directory need to appear in distdir, or whether the related utility should be removed based on future rules_js needs; the issue is done when the chosen path is reflected in the repository and distdir behavior.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.