cockroachdb / cockroachdb/cockroach
admission: lower physical cluster replication to background work priority
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
**Is your feature request related to a problem? Please describe.**
PCR currently uses normal admission control priority, meaning it won't be subject to replication AC. We saw that this can lead to uncontrolled IO overload, as follower writes bypass AC:

**Describe the solution you'd like**
Lower the admission control work priority of PCR to background here:
https://github.com/cockroachdb/cockroach/blob/935d796608663c74b726ad42659cd91aa502d11b/pkg/ccl/streamingccl/streamingest/stream_ingestion_processor.go#L992-L995
Jira issue: CRDB-37721
Contributor guide
Research direction
Start in pkg/ccl/streamingccl/streamingest/stream_ingestion_processor.go around lines 992-995, where the physical cluster replication admission control work priority is set. Trace the surrounding PCR admission-control setup and verify that its priority is background so follower writes are subject to replication admission control.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100