cockroachdb / cockroachdb/cockroach

cli_test: zip tests too prescriptive about unrelated internal tables

Open
#120,635 0 comments 0 reactions 0 assignees View on GitHub
C-cleanup
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Currently adding or renaming an internal table in crdb_internal causes changes in many tests pkg/cli to fail. Some of these make sense and are reasonable, for example the test that asserts every internal table is either included in a zip or opted out. But the others, that incidentally are capturing the specification of the exact set of internal tables just because they assert e.g. certain log messages are observed are overly specific about unrelated functionality. Adding an _internal_ debug table with no callers/users should not update 15+ files.

Jira issue: CRDB-36794

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.