cockroachdb / cockroachdb/cockroach

tests: pkg/sql/opt/xform too sensitive to internal IDs

Open
#120,629 0 comments 0 reactions 0 assignees View on GitHub
C-cleanup E-quick-win T-sql-queries
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

The git history of the tests in pkg/sql/opt/xform, specifically on testdata/external/*, show that every modification to the internal debugging tool some distance away in crdb_internal causes churn in these tests. Validating the content of crdb_internal is not the responsibility of these tests, so they should be adjusted to be less specific about unrelated changes in another part of the system, e.g. by regex'ing out the IDs before asserting their expected output.

Jira issue: CRDB-36791

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.