cockroachdb / cockroachdb/cockroach

changefeedccl: warn users creating changefeed with unsupported config options

Open
#120,567 2 comments 0 reactions 0 assignees View on GitHub
A-cdc C-bug T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Users can specify sink-specific configuration options in a json config, but not all sinks support the same configuration options. Currently, if unsupported options are included, the changefeed will succeed but will silently ignore those options, as in the following example:

```
CREATE CHANGEFEED FOR TABLE bank INTO 'gcpubsub://cockroach-khancox?REGION=us-central1&AUTH=specified&CREDENTIALS=redacted' WITH unordered, envelope=bare, pubsub_sink_config = '{ "Flush": {"Messages": 100, "Frequency": "5s"}, "Retry": { "Max": 4, "Backoff": "10s"}, "RequiredAcks": "ONE", "Compression": "lz4"}', format=csv, initial_scan='only';
```

We should at least log a warning when the configuration includes an unsupported option.

Jira issue: CRDB-36751

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.