cockroachdb / cockroachdb/cockroach

roachtest: regenerate BACKUP fixtures for TPCC/TPCH tests

Open
#120,146 1 comment 0 reactions 0 assignees View on GitHub
A-testeng-foundations A-testing C-enhancement E-starter T-testeng
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

In this thread, we realized that TPCC and TPCH test fixtures use backups that are several years old: https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1709912020888919?thread_ts=1709896031.584779&cid=C023S0V4YEB

We no longer support restoring from backups taken from more than 1 major version ago. (Or 2, if we're in a branch that supports version skipping.)

We should regenerate the fixtures.

https://github.com/cockroachdb/cockroach/issues/120124 is an example of a failure that was caused by this, with many other issues linked to it.

https://github.com/cockroachdb/cockroach/pull/120147 works around this issue by adding a post-restore descriptor change, so tests stop failing, but we still should tackle this tech debt and update the fixtures.

Jira issue: CRDB-36509

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.