cockroachdb / cockroachdb/cockroach
kvcoord: DistSender circuit breaker benchmarking and optimization
Open
A-kv-client
C-performance
T-kv
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
The DistSender circuit breakers added in https://github.com/cockroachdb/cockroach/pull/118943 need additional benchmarking and performance testing, particularly at large scale and high concurrency. We should consider using a `sync.Map` or `IntMap` variant, look at the effect of large numbers of probes (e.g. when a high-density node's disk stalls), consider batching probes, and use a `sync.Pool` for circuit breaker construction.
Jira issue: CRDB-36388
Contributor guide
Assessment
This issue has not been assessed yet.