cockroachdb / cockroachdb/cockroach

multi-tenant: enable memmonitoring profiler in application tenant

Open
#119,530 1 comment 0 reactions 0 assignees View on GitHub
A-disaster-recovery A-multitenancy C-enhancement O-testcluster P-2 T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

As mentioned by @yuzefovich in the investigation of #119384, we're currently hampered in our ability to diagnose memory related errors in the application tenant due to the lack of the `memmonitoring` profiler:

> Currently we disable all "runtime stats" profilers in shared-process config, and it makes sense for all proper "runtime stats", but the memory accounting profiler dumps the state of SQL accounting system, so we only get system tenant's view which is insufficient. (This profiler was added recently in https://github.com/cockroachdb/cockroach/pull/114275.)

We should add this profiler to the application tenant for better debuggability of UA-enabled clusters.

Jira issue: CRDB-36270

Contributor guide

Open the contributing guide

Research direction

Start by locating the shared-process configuration that disables runtime-stats profilers and the existing memmonitoring profiler added in PR #114275. Trace how profiler availability differs between system and application tenants, then enable memmonitoring for the application tenant and verify that its dumps include the application tenant's SQL accounting state.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
databases, observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.