cockroachdb / cockroachdb/cockroach

batcheval: rate limit the scan in RecomputeStats

Open
#119,501 2 comments 0 reactions 0 assignees View on GitHub
A-kv C-enhancement T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

As a result of #119499, potentially many more ranges will have their stats re-computed as part of the consistency checker queue processing. The invocations of `RecomputeStats` from the consistency checker are rate-limited so we don't have bursts of re-computation for all ranges. But within a single call to `RecomputeStats`, the underlying scan is not rate-limited.

We should do something similar to the [consistencyLimiter](https://github.com/cockroachdb/cockroach/blob/cc27780ffbf291e85db185c786ca516b42198fc6/pkg/kv/kvserver/store.go#L861).

Jira issue: CRDB-36260

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.