cockroachdb / cockroachdb/cockroach

backupccl: better test range bound export requests

Open
#115,575 0 comments 0 reactions 1 assignee Claimed by @msbutler View on GitHub
C-enhancement
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

https://github.com/cockroachdb/cockroach/pull/114268 split backup export request spans to be bound by existing ranges. We ought to better test this behavior in a unit test. Here's one way to do this:

1. Begin a backup of an empty table, halt it just after distsql planning via a testing hook
2. Split the table into 100 ranges
3. Ensure if `bulkio.backup.presplit_request_spans.enabled` is true, we send around 100 export requests.

Jira issue: CRDB-34109

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.