cockroachdb / cockroachdb/cockroach

admission: indexBackfiller should be subject to elastic CPU control

Open
#115,421 0 comments 0 reactions 0 assignees View on GitHub
A-admission-control C-enhancement O-23.2-scale-testing O-testcluster T-admission-control
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

It is already considered elastic work wrt store writes, so considering it the same wrt CPU is consistent.

This is the profile mentioned in https://cockroachlabs.slack.com/archives/C067NG669KJ/p1701397203699929?thread_ts=1701395533.260899&cid=C067NG669KJ. Making this change may be hard -- some of this CPU happens in:
- grpc when sending the addSSTable
- building the index entries in the context of a transaction (in the client). We may not want to prolong how long the (read-only?) transaction needs to stay open.

Screenshot 2023-12-01 at 9 01 53 AM

Jira issue: CRDB-34024

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.