cockroachdb / cockroachdb/cockroach

doctor: throw a better error on fail in roachtests

Open
#114,722 0 comments 0 reactions 0 assignees View on GitHub
A-sql-cli-observability C-enhancement T-sql-foundations
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**
The output of `debug doctor examine cluster` can fail with a non-descriptive error:

```
run_154213.137443734_n1_cockroach-debug-doct: 15:42:13 cluster.go:2189: > ./cockroach debug doctor examine cluster --certs-dir certs
ERROR: current transaction is aborted, commands ignored until end of transaction block
SQLSTATE: 25P02
Failed running "debug doctor examine cluster"
run_154213.137443734_n1_cockroach-debug-doct: 15:42:13 cluster.go:2196: > result: COMMAND_PROBLEM: exit status 1
```

**To Reproduce**

This happens in the schemachange/mixed-versions roachtest on the new mixed-version framework when there is no restriction on `NumUpgrades` (i.e. if a test plan shows that we will upgrade from 22.2 to current - 23.2).

**Expected behavior**
We should have a more verbose error message on a failure like this.

Jira issue: CRDB-33653

Epic CRDB-60947

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.