cockroachdb / cockroachdb/cockroach
kvserver: consistency checker prints self in set of all replicas
Open
A-kv-replication
C-enhancement
O-23.2-scale-testing
O-testcluster
T-kv
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
When the consistency checker fires, it prints a message of the following form:
```
[n41,s404,r1081383/5:‹/Table/106/1/15822{257…-339…}›]
and its other replicas: (n39,s382):6,(n41,s404):5,(n18,s189):4
```
[We print `r1081383/5`, but it also appears in the slice of "other replicas".](https://github.com/cockroachdb/cockroach/blob/b3d6b392389b553966b2cd89a712394aceb9eda4/pkg/kv/kvserver/replica_consistency.go#L841) This is mildly confusing / annoying.
Instead, we could do something like a set subtraction of "self" from its replicas.
More context ([internal](https://cockroachlabs.slack.com/archives/C05VAJ5H3QS/p1699975198550499)).
Jira issue: CRDB-33504
Contributor guide
Assessment
This issue has not been assessed yet.