cockroachdb / cockroachdb/cockroach

jobs: enter the paused state only after the resumer returns

Open
#113,240 0 comments 0 reactions 0 assignees View on GitHub
A-jobs C-enhancement T-jobs
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Currently, the `paused-requested` -> `paused` state transitions happens when the job system cancels job's context rather than when the resumer actually returns. So, Resumer code could still be running even if the jobs table indicates the job is paused. This seems sad.

As @stevendanna notes: "The thing to think through is the semantics of the state transitions in cases where the owning node has become unavailable. You will never have a guarantee that the resumer isn't still running somewhere. So it is also probably worth thinking about whether we actually need to change the current semantics for anything other than me being occasionally annoyed by it."

Jira issue: CRDB-32824

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.