cockroachdb / cockroachdb/cockroach

cli: investigate why TestZipJobTrace does not work with a shared process virtual cluster

Open
#112,950 0 comments 0 reactions 0 assignees View on GitHub
A-multitenancy C-investigation T-db-server
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

When running the test with a shared process virtual cluster:
```
zip_test.go:980:
Error Trace: /Users/herko/go/src/github.com/cockroachdb/cockroach/pkg/cli/zip_test.go:980
Error: Expect "" to match "/jobs/911187579317649409/.*/trace.zip
/jobs/911187579333214209/.*/trace.zip
"
Test: TestZipJobTrace
```

**How to reproduce**

Set the following in `TestServerArgs` to force a shared process tenant and cause the failure to happen.
```
DefaultTestTenant: base.SharedTestTenantAlwaysEnabled,
```

**Expected behavior**
The test should pass when running with a shared process virtual cluster, unless after investigation the test is expected not to work with one.

Ref: https://github.com/cockroachdb/cockroach/issues/112857
Epic CRDB-38970

Jira issue: CRDB-32688

Contributor guide

Open the contributing guide

Research direction

Start with TestZipJobTrace in pkg/cli/zip_test.go around line 980, reproducing it with DefaultTestTenant set to base.SharedTestTenantAlwaysEnabled. Trace why the shared process virtual cluster produces no matching trace paths, then determine whether the test should support that configuration or explicitly not. Done means the expected behavior is documented and the test passes or has a justified expectation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, distributed-systems, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.