cockroachdb / cockroachdb/cockroach

server: improve handling of ambiguous liveness writes on decommission

Open
#112,918 1 comment 0 reactions 0 assignees View on GitHub
C-bug T-kv
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

From #109883 [thread](https://github.com/cockroachdb/cockroach/issues/109883#issuecomment-1746029559):

> If a liveness KV write with the DECOMMISSIONED membership status for the "self" NodeID is ambiguous, the write is unknown to have failed, or to have succeeded. If the ambiguous write failed, retrying is totally idempotent and allowed - the retry can succeed, and the status can be returned just fine. If the ambiguous write succeeded, however, a retry is not allowed, as KV API usage is not permitted once a node's DECOMMISSIONED status has propagated through gossip and has been written to the decommissioned node tombstone storage. This is a real bug, though in practice it is relatively harmless (only affecting status reporting to the CLI) and I'd imagine exceedingly rare outside test scenarios, so I'm not sure this warrants the release-blocker label.

Jira issue: CRDB-32680

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.