cockroachdb / cockroachdb/cockroach

changefeedccl: investigate why TestSQLSink does not work with a shared process virtual cluster

Open
#112,863 1 comment 0 reactions 0 assignees View on GitHub
A-cdc A-multitenancy C-investigation T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

`TestSQLSink` fails with (when running a shared process virtual cluster):
```
Error Trace: /Users/herko/go/src/github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/sink_test.go:500
Error: Received unexpected error:
unknown SQL sink query parameters: options
(1) attached stack trace
-- stack trace:
| github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.makeSQLSink
| /Users/herko/go/src/github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/sink_sql.go:98
| github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl.TestSQLSink
| /Users/herko/go/src/github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/sink_test.go:499
```

**How to reproduce**

Set the following in `TestServerArgs` to force a shared process tenant
```
DefaultTestTenant: base.SharedTestTenantAlwaysEnabled,
```

**Expected behavior**
The test should pass when running with a shared process virtual cluster, unless after investigation the test is expected not to work with one.

Ref: https://github.com/cockroachdb/cockroach/issues/112857
Epic: CRDB-26687

Jira issue: CRDB-32648

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.