cockroachdb / cockroachdb/cockroach

kvserver: warning about empty admissison headers

Open
#112,680 30 comments 0 reactions 0 assignees View on GitHub
A-admission-control branch-release-23.2 C-bug O-cct O-testcluster P-3 T-admission-control
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

When reading through logs I've been seeing this:

```
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 empty admission header provided by goroutine 3952 [running]:
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 +runtime/debug.Stack()
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 + GOROOT/src/runtime/debug/stack.go:24 +0x64
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 +github.com/cockroachdb/cockroach/pkg/kv/kvserver/intentresolver.(*IntentResolver).resolveIntents(0x1400107e280, {0x1082fdc88, 0x14008ca4a20}, {0x1082d2f90, 0x14008
63e708}, {0x1, {0x0, 0x0, 0x0}, {0x0, ...}, ...})
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 + github.com/cockroachdb/cockroach/pkg/kv/kvserver/intentresolver/intent_resolver.go:1029 +0x234
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 +github.com/cockroachdb/cockroach/pkg/kv/kvserver/intentresolver.(*IntentResolver).ResolveIntents(...)
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 + github.com/cockroachdb/cockroach/pkg/kv/kvserver/intentresolver/intent_resolver.go:997
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 +github.com/cockroachdb/cockroach/pkg/kv/kvserver/intentresolver.(*IntentResolver).CleanupIntents(0x1400244ad58?, {0x1082fdc88, 0x14008ca4a20}, {0x0, 0x0, 0x0, 0x0,
0x0}, {0x14005e90f00, 0x1, ...}, ...)
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 + github.com/cockroachdb/cockroach/pkg/kv/kvserver/intentresolver/intent_resolver.go:595 +0x2b0
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 +github.com/cockroachdb/cockroach/pkg/kv/kvserver/intentresolver.(*IntentResolver).CleanupIntentsAsync.func1.1({0x1082fdc88?, 0x14008ca4a20?})
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 + github.com/cockroachdb/cockroach/pkg/kv/kvserver/intentresolver/intent_resolver.go:517 +0x64
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 +github.com/cockroachdb/cockroach/pkg/util/timeutil.RunWithTimeout({0x1082fdcc0?, 0x14008bb4120?}, {0x10603b978, 0x17}, 0x6fc23ac00, 0x1400244aec0)
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 + github.com/cockroachdb/cockroach/pkg/util/timeutil/timeout.go:29 +0x90
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 +github.com/cockroachdb/cockroach/pkg/kv/kvserver/intentresolver.(*IntentResolver).CleanupIntentsAsync.func1({0x1082fdcc0, 0x14008bb4120})
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 + github.com/cockroachdb/cockroach/pkg/kv/kvserver/intentresolver/intent_resolver.go:515 +0xb8
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 +github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2()
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 + github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:484 +0x128
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 +created by github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx
W231019 09:51:14.423104 3952 kv/kvserver/intentresolver/intent_resolver.go:1029 [-] 281 + github.com/cockroachdb/cockroach/pkg/util/stop/stopper.go:475 +0x33c
```

Is this something unexpected that we should be fixing? I imagine the goal of this log was to identify places that might benefit from admission headers.

Jira issue: CRDB-32550

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.