cockroachdb / cockroachdb/cockroach

cli,jobs: remove hardcoded job type list from debug zip

Open
#112,192 1 comment 0 reactions 0 assignees View on GitHub
A-disaster-recovery C-enhancement T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

In https://github.com/cockroachdb/cockroach/pull/112130 we hardcoded a list of job types that currently implement the Traceable job interface. This list is the only set of job types for which we want to request cluster-wide traces since others job types will not execute with tracing span's with recording enabled. This list is bound to rot as and when new jobs implement this Traceable job interface. We should solve this by adding a column to the jobs table that says to run with tracing enabled or not. This column will be populated by the resumers what know their code has relevant trace events in it or via explicit action/settings. This way we can remove the Traceable job interface, and the query to find all jobs with tracing enabled can add an extra `WHERE` clause to filter only the rows we care about.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.