cockroachdb / cockroachdb/cockroach

`SHOW CREATE EXTERNAL CONNECTION` does not redact secret keys

Open
#111,503 1 comment 0 reactions 0 assignees View on GitHub
A-disaster-recovery C-bug T-disaster-recovery
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

Using `SHOW CREATE ALL EXTERNAL CONNECTIONS` noticed that secrets keys for the storage URI are not redacted. Perhaps this is desirable for `root`/`admin`, or the person who created it. Filing this issue to check whether there could be any improvements around this, as per discussion with @adityamaru.

`SHOW CREATE SCHEDULES` seems to redact even for the user who created the schedule.

**To Reproduce**

Create an external connection, and then run `SHOW CREATE EXTERNAL CONNECTION` on that ext conn.

**Expected behavior**

Probably what the general behavior is across all `SHOW CREATE` depending on privileges and such, not sure what the overall policy is here.

Jira issue: CRDB-31937

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.