cockroachdb / cockroachdb/cockroach
changefeedccl: emittedmessages metric resolved messages semantics aren't consistent
Open
A-cdc
C-bug
E-easy
T-cdc
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
Some sinks will enqueue resolved messages, but still increment the `emittedmessages` metric. For example, see https://github.com/cockroachdb/cockroach/blob/d1c1727e0fc5c3b8d3d97a48fbaabf3bf1f3a9fc/pkg/ccl/changefeedccl/sink_kafka.go#L359-L408.
This is inconsistent behavior because some sinks will only increment the metric when the resolved message is successfully sent.
Jira issue: CRDB-31739
Contributor guide
Assessment
This issue has not been assessed yet.