cockroachdb / cockroachdb/cockroach
changefeedccl: improve test coverage for metrics
Open
A-cdc
C-bug
T-cdc
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
There is not enough test coverage for metrics. Most of these SLI metrics have no test coverage.
- [ ] EmittedMessages https://github.com/cockroachdb/cockroach/issues/111043
- [ ] FilteredMessages
- [ ] MessageSize
- [ ] EmittedBytes
- [ ] FlushedBytes
- [ ] BatchHistNanos
- [ ] Flushes
- [ ] FlushHistNanos
- [ ] SizeBasedFlushes
- [ ] ParallelIOQueueNanos
- [ ] SinkIOInflight
- [ ] CommitLatency
- [ ] ErrorRetries
- [ ] AdmitLatency
- [ ] BackfillCount
- [ ] BackfillPendingRanges
- [ ] RunningCount
- [ ] BatchReductionCount
- [ ] InternalRetryMessageCount
- [ ]
There likely isn't much test coverage for non-sli metrics either.
Jira issue: CRDB-31738
Contributor guide
Assessment
This issue has not been assessed yet.