cockroachdb / cockroachdb/cockroach
rangefeed: better prioritization of system tables
Open
A-kv-rangefeed
C-performance
T-kv
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
Rangefeeds should give priority to system tables, for example in the rangefeed scheduler or memory budgets. Currently, we have some ad hoc prioritization based on the start key and `MaxReservedDescID`, but this is no longer accurate with dynamic system tables (see #57531). To find out, we need to check the SQL table descriptor via `catalog.IsSystemDescriptor()`, but we don't have easy access to this below KV in the rangefeed machinery.
The best approach here is probably to let the client decide the priority based on whether it considers itself a system rangefeed.
Related to #110568.
Jira issue: CRDB-31659
Contributor guide
Assessment
This issue has not been assessed yet.