cockroachdb / cockroachdb/cockroach

server: clarify "KV node dialer" vs "sql instance dialer"

Open
#110,249 0 comments 0 reactions 0 assignees View on GitHub
C-enhancement T-db-server
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

Requested by @stevendanna here https://github.com/cockroachdb/cockroach/pull/110008/files#r1319665539

Currently the code uses the same identifier `nodeDialer` for both cases in some places.
Also, the word "podNodeDialer" is used in a few places where really it means "sql instance dialer".

This should be clarified.

Epic: CRDB-28893

Jira issue: CRDB-31345

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.