cockroachdb / cockroachdb/cockroach

serverutils: consider granting all tenant capabilities by default

Open
#109,477 0 comments 0 reactions 0 assignees View on GitHub
C-cleanup T-multitenant
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

#109449 adds overrides to existing cluster settings that gate some functionality in the virtual clusters to be enabled by default. The rationale is that that we have more tests that want this than those that need precise control of what's enabled.

We should also consider simply granting all tenant capabilities by default too (unless the caller explicitly asks not to). We do need to be mindful that waiting for capabilities can have non-trivial overhead which can slowdown the CI pipeline (but perhaps 132211f7d7eb310ecdcb69a12a36c6a5cc0a2311 made it quick enough).

Jira issue: CRDB-30943

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.