cockroachdb / cockroachdb/cockroach

workload: incorrect check for split at / scatter with cluster virtualization

Open
#109,422 0 comments 0 reactions 0 assignees View on GitHub
A-multitenancy C-bug T-multitenant
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

In `workload/workloadsql/workloadsql.go`:

```go
if strings.Contains(err.Error(), errorutil.UnsupportedUnderClusterVirtualizationMessage) {
// We don't care about split errors if we're running a workload
// with virtual clusters; we can't do them so we'll just continue.
break
}
```

1) SPLIT AT and SCATTER are possible with virtual clusters with the right capability
2) even when pointing `workload` to a secondary tenant without the capability, the error should be "capability missing", not "operation not supported". So the error check is incorrect.

Epic: CRDB-26687.

Jira issue: CRDB-30917

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.