cockroachdb / cockroachdb/cockroach

changefeedccl: TestChangefeedNemeses and TestCatchupScanOrdering incorrectly skip using secondary tenants

Open
#109,417 1 comment 0 reactions 0 assignees View on GitHub
A-cdc C-bug T-cdc
Dominant language
Go
Stars
32.5k
Forks
4.1k
PR merge metrics
PR metrics pending

Description

**Describe the problem**

in `changefeedccl > nemeses_test.go`:

```go
// Tenant tests disabled because ALTER TABLE .. SPLIT is not
// supported with cluster virtualization:
//
// nemeses_test.go:39: pq: unimplemented: operation is unsupported inside virtual clusters
cdcTest(t, testFn, feedTestNoTenants)
```

Ditto in `validations_test.go`:

```go
// Tenant tests disabled because ALTER TABLE .. SPLIT is not
// supported with cluster virtualization:
//
// nemeses_test.go:39: pq: unimplemented: operation is unsupported inside virtual clusters
//
// TODO(knz): This seems incorrect, see issue #109417.
cdcTest(t, testFn, feedTestNoTenants)
```

**Expected behavior**

Since SPLIT AT can be used from secondary tenants (with suitable capability), this test should be made to work this way.

Epic: CRDB-26687

Jira issue: CRDB-30914

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.