cockroachdb / cockroachdb/cockroach
builtins: crdb_internal.request_statement_bundle should format query and ignore whitespace
Open
A-cluster-observability
C-bug
T-observability
- Dominant language
- Go
- Stars
- 32.5k
- Forks
- 4.1k
- PR merge metrics
- PR metrics pending
Description
`crdb_internal.request_statement_bundle` does not run queries through the fn that would parse and generate a statement fingerprint (replacing placeholders with $1 and wrapping clauses in brackets, etc). Instead, the raw string input to the function is used. This can lead to user errors where for example a fingerprint might be inputted to the function with improper formatting. We should do some validation and formatting of the query to ensure the input is valid.
Jira issue: CRDB-30699
Epic CRDB-32397
Contributor guide
Assessment
This issue has not been assessed yet.